Fix binary location tracking of wrapped expressions - #8960
Open
sbc100 wants to merge 1 commit into
Open
Conversation
Fixes assertion failure in `AddrExprMap::add` introduced in #8862. When `maybeWrapForLabel` creates a synthetic block around a `Try` or `If` expression, `push` is called on the synthetic block rather than the underlying expression. Update `expressionLocations.end` for the inner expression when closing its scope in `visitEnd`, and push synthetic wrapper blocks with `pushSynthetic` so they are not tracked as duplicate binary instructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed AI solution for assertion failure in
AddrExprMap::addintroduced in #8862. I don't understand this code myself.When
maybeWrapForLabelcreates a synthetic block around aTryorIfexpression,pushis called on the synthetic block rather than the underlying expression. UpdateexpressionLocations.endfor the inner expression when closing its scope invisitEnd, and push synthetic wrapper blocks withpushSyntheticso they are not tracked as duplicate binary instructions.