fix: stop calling deprecated PuffinFile.to_vector in Spark DV test - #3804
fix: stop calling deprecated PuffinFile.to_vector in Spark DV test#3804daviddallakyan2005 wants to merge 1 commit into
Conversation
|
Thanks for catching and fixing this, @daviddallakyan2005, and sorry for the noise — the broken call came in with #3476. For the record on the root cause: #3476's last commit was 2026-06-18, and #3491 deprecated The fix looks right to me. |
|
This is simply a logical conflict. No need to apologize :) We could consider enabling the merge queue so that we can re-run CI just before its merge. Here's a reference: |
Closes #3803
Rationale for this change
Follow-up to #3476.
test_read_spark_written_puffin_dvstill callsPuffinFile.to_vector(), which #3491 deprecated in 0.12.0.filterwarnings = ["error"]turns that into a hard CI failure, sointegration-testis red onmainand on unrelated PRs including #3801.This test now uses
deletion_vectors_from_puffin_file(...), matchingpyiceberg/io/pyarrow.py. Spark interop assertions are unchanged. Not part of #3801.Are these changes tested?
Yes.
make test-integration PYTEST_ARGS="-v -k test_read_spark_written_puffin_dv"→ 1 passed, 5517 deselected.Are there any user-facing changes?
No.