Spark: Fix deprecated PuffinFile.to_vector call in test_read_spark_written_puffin_dv - #3806
Closed
Alwaysgaurav1 wants to merge 1 commit into
Closed
Spark: Fix deprecated PuffinFile.to_vector call in test_read_spark_written_puffin_dv#3806Alwaysgaurav1 wants to merge 1 commit into
Alwaysgaurav1 wants to merge 1 commit into
Conversation
…itten_puffin_dv (apache#3803) Update test_read_spark_written_puffin_dv to use deletion_vectors_from_puffin_file instead of deprecated PuffinFile.to_vector(), preventing integration test failure under filterwarnings = ["error"]. Fixes apache#3803.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Spark integration test failure caused by treating DeprecationWarning as an error by removing the deprecated PuffinFile.to_vector() call from the Puffin deletion-vector interop test.
Changes:
- Replace deprecated
puffin.to_vector()usage withdeletion_vectors_from_puffin_file(puffin)in the Spark-written Puffin DV integration test. - Call
dv.to_vector()on each returnedDeletionVectorinstance to obtain thepyarrow.ChunkedArrayfor assertions.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3803.
test_read_spark_written_puffin_dvwas invoking deprecatedPuffinFile.to_vector(), which raised aDeprecationWarningand caused CI integration test failures underfilterwarnings = ["error"].This PR replaces the deprecated call with
deletion_vectors_from_puffin_file(puffin)and callsdv.to_vector()directly on eachDeletionVectorinstance.