Skip to content

Spark: Fix deprecated PuffinFile.to_vector call in test_read_spark_written_puffin_dv #3806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Alwaysgaurav1 wants to merge 1 commit into from
+5 −3
Closed

Spark: Fix deprecated PuffinFile.to_vector call in test_read_spark_written_puffin_dv #3806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tests/integration/test_deletes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
from pyiceberg.partitioning import PartitionField, PartitionSpec
from pyiceberg.schema import Schema
from pyiceberg.table import Table
from pyiceberg.table.deletion_vector import deletion_vectors_from_puffin_file
from pyiceberg.table.puffin import PuffinFile
from pyiceberg.table.snapshots import Operation, Summary
from pyiceberg.transforms import IdentityTransform
Expand Down Expand Up @@ -1081,10 +1082,11 @@ def test_read_spark_written_puffin_dv(spark: SparkSession, session_catalog: Rest
assert "referenced-data-file" in blob.properties
assert blob.properties["cardinality"] == "4"

dv_dict = puffin.to_vector()
assert len(dv_dict) == 1, "Expected one data file's deletions"
dvs = deletion_vectors_from_puffin_file(puffin)
assert len(dvs) == 1, "Expected one data file's deletions"

for _data_file_path, chunked_array in dv_dict.items():
for dv in dvs:
chunked_array = dv.to_vector()
positions = chunked_array.to_pylist()
assert len(positions) == 4, f"Expected 4 deleted positions, got {len(positions)}"
assert sorted(positions) == [9, 19, 29, 39], f"Unexpected positions: {positions}"