SolrRequest.setPath fix; allow null - #4686
Merged
Merged
Conversation
Contributor
Just looking at the diff, I would urge you to keep updating the many callers.. It's just so much more readable, and we need to get to the other side of having two ways of doing things... This looks great! |
…e same validation.
epugh
approved these changes
Jul 31, 2026
epugh
left a comment
epugh
left a comment
Contributor
There was a problem hiding this comment.
personally liked the other route, but totally understand scope. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and the constructor should use the same validation.
Fixes a regression in #4665
Updated some callers of setPath that consulted "qt" to no longer do so because it is no longer necessary. I can separate this to another PR if asked.
I held back from updating many callers of setPath to use the QueryRequest constructor, which is nicer IMO.