Skip to content

SolrRequest.setPath fix; allow null #4686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsmiley merged 2 commits into from
Aug 1, 2026
+7 −4
Merged

SolrRequest.setPath fix; allow null #4686

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad7e704
SolrRequest.setPath fix; allow null and the constructor should use th…
dsmiley Jul 31, 2026
733c539
extract validate so isn't overridden
dsmiley Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ public String getBasicAuthPassword() {

public SolrRequest(METHOD m, String path, SolrRequestType requestType) {
this.method = m;
this.path = path;
this.path = validatePath(path);
this.requestType = requestType;
}

Expand All @@ -182,11 +182,14 @@ public String getPath() {
}

public void setPath(String path) {
if (path == null || !path.startsWith("/")) {
this.path = validatePath(path);
}

private static String validatePath(String path) {
if (path != null && !path.startsWith("/")) {
throw new IllegalArgumentException("Must start with a '/': " + path);
}

this.path = path;
return path;
}

/**
Expand Down
Loading