refactor: make context configuration consumer-owned - #26
Merged
codeforester merged 1 commit intoAug 1, 2026
Merged
Conversation
codeforester
marked this pull request as ready for review
August 1, 2026 02:32
codeforester
deleted the
enhancement/23-20260731-generalize-context-config-api
branch
August 1, 2026 02:32
codeforester
added a commit
to basefoundry/base
that referenced
this pull request
Aug 1, 2026
## Summary - move Base-owned `UserConfig` dataclasses and parsing types into `base_cli_adapters` - adapt Base's profile to pass opaque consumer configuration and project its workspace root through the generic profile callback - replace Base's reads of the removed `Context.base_home` field with neutral `Context.application_home` ## Validation - `PYTHONPATH=/Users/rameshhp/work/base-cli-worktrees/23-generalize-context-config-api/lib/python:cli/python /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest cli/python -q` - `841 passed, 1 skipped, 248 subtests passed` - `git diff --check` Depends on basefoundry/base-cli#26. Fixes #1841
This was referenced Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base_cli.configmoduleContext.user_configopaque and project workspace-root projection throughCliProfileValidation
uv run --extra dev pytest -qThe coordinated Base consumer migration is in basefoundry/base#1841.
Fixes #23