Fix doctor failure summary severity - #1911
Merged
codeforester merged 1 commit intoAug 8, 2026
Merged
Conversation
codeforester
deleted the
bug/1895-20260808-doctor-failure-summary-severity
branch
August 8, 2026 21:03
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raise the final blocking-issue summary from INFO to ERROR when
basectl doctorfails.Why
The command returned a non-zero status while its final count was hidden from warn/error-level log consumers. Both regular and CI-runtime text paths had this behavior.
Impact
Failed doctor runs now retain their final blocking-issue count in error-level output. Successful summaries remain INFO.
Root cause
Both failure branches called
base_std_log_infoimmediately before returning 1.Validation
bats cli/bash/commands/basectl/tests/doctor.bats(29 passed)bats cli/bash/commands/basectl/tests/ci.bats(7 passed)shellcheck cli/bash/commands/basectl/subcommands/doctor.shgit diff --check origin/main...HEADAI context
.ai-context/is unchanged: this is a small diagnostic severity correction with no architecture or command-surface change.Fixes #1895