Skip to content

Fix doctor failure summary severity #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeforester merged 1 commit into from
Aug 8, 2026
Merged

Fix doctor failure summary severity #1911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cli/bash/commands/basectl/subcommands/doctor.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,9 +237,9 @@ base_doctor_run_ci_runtime_text() {
fi

if [[ -n "$project" ]]; then
base_std_log_info "Base CI doctor found $errors blocking issue(s) for project '$project'."
base_std_log_error "Base CI doctor found $errors blocking issue(s) for project '$project'."
else
base_std_log_info "Base CI doctor found $errors blocking issue(s)."
base_std_log_error "Base CI doctor found $errors blocking issue(s)."
fi
return 1
}
Expand Down Expand Up @@ -427,9 +427,9 @@ base_doctor_subcommand_main() {
fi

if [[ -n "$project" ]]; then
base_std_log_info "Base doctor found $errors blocking issue(s) for project '$project'."
base_std_log_error "Base doctor found $errors blocking issue(s) for project '$project'."
else
base_std_log_info "Base doctor found $errors blocking issue(s)."
base_std_log_error "Base doctor found $errors blocking issue(s)."
fi
return 1
}
11 changes: 11 additions & 0 deletions cli/bash/commands/basectl/tests/ci.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,17 @@ prepare_ci_runtime() {
[ "$(cat "$TEST_STATE_DIR/project-setup-ci")" = "true" ]
}

@test "basectl doctor --ci logs a blocking summary at error level" {
create_system_python3_stub
create_project_setup_venv_stub "$TEST_HOME/.base.d/base/.venv"
touch "$TEST_STATE_DIR/pyyaml-installed"

run_base_command OSTYPE=linux-gnu doctor --ci base

[ "$status" -eq 1 ]
[[ "$output" == *" ERROR "*"Base CI doctor found 1 blocking issue(s) for project 'base'."* ]]
}

@test "basectl setup --ci json output summarizes stderr without embedding log stream" {
local workspace="$TEST_TMPDIR/workspace"

Expand Down
2 changes: 1 addition & 1 deletion cli/bash/commands/basectl/tests/doctor.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ EOF
[[ "$output" == *"error"*"Homebrew"*"Homebrew is not installed."* ]]
[[ "$output" == *"Fix: Run 'basectl setup' to install Homebrew, or install it manually from https://brew.sh/."* ]]
[[ "$output" == *$'\n Fix: Run '\''basectl setup'\'' to install Homebrew, or install it manually from https://brew.sh/.'* ]]
[[ "$output" == *" INFO "*"Base doctor found"*"blocking issue(s)."* ]]
[[ "$output" == *" ERROR "*"Base doctor found"*"blocking issue(s)."* ]]
[[ "$output" != *$'\n\n'*"Base doctor found"* ]]
}

Expand Down
Loading