Repository navigation
Migrate github.com/SermoDigital to github.com/golang-jwt for 1.27.0 c… - #3872
Merged
prkalle merged 1 commit intoOct 5, 2026
Conversation
prkalle
approved these changes
Oct 1, 2026
prkalle
left a comment
prkalle
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Thanks for the changes @benjaminguttmann-avtq !
|
+1 I am being burned by this error when trying to build plugins as well when trying to use go1.27 Looking forward having this merged asap. |
|
+1 Thanks @benjaminguttmann-avtq Autoscaler CLI plugin cannot use go 1.27.1 due to the same problem |
1 task
norman-abramovitz
pushed a commit
to cloudfoundry/stratos
that referenced
this pull request
Oct 13, 2026
SermoDigital/jose panics at init under Go 1.27, so both modules replaced it with the norman-abramovitz/fw-jose fork. CLI v8 now uses golang-jwt v5 (cloudfoundry/cli#3872, merged on v8, untagged), so pin the v8 head as a pseudo-version and drop both replaces. Swap in the release tag once v8 is tagged. The move also brings grpc 1.84.0 and small indirect bumps. All seven modules are tidied; none references jose any more.
norman-abramovitz
added a commit
to cloudfoundry-community/ocf-scheduler-cf-plugin
that referenced
this pull request
Oct 13, 2026
The fix for the Go 1.27 jose panic (cloudfoundry/cli#3872) moved the CLI to golang-jwt, but only on the v8 branch, whose module path is code.cloudfoundry.org/cli/v8. No release carries it yet, so pin the merge commit 4fe13a52 and import the plugin packages from /v8. The v8 module brings newer dependencies with it, including k8s client-go and grpc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ompat
Thank you for contributing to the CF CLI! Please read the following:
Note: Please create separate PR for every branch (main and v8) as needed.
Description of the Change
This PR switches from using github.com/SermoDigital to use github.com/golang-jwt as there are issues with SermoDigital and golang 1.27.0 (https://github.com/cloudfoundry/cf_exporter/actions/runs/32944433448/job/98102027604).
v8 version of PR #3852
Note: PR has been created with the usage of AI
Why Is This PR Valuable?
Makes it possible to bump golang to v1.27.0.
Applicable Issues
List any applicable GitHub Issues here
How Urgent Is The Change?
Is the change urgent? If so, explain why it is time-sensitive.
Other Relevant Parties
Who else is affected by the change?
ry/cli/blob/main/.github/CONTRIBUTING.md)
If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
Note: Please create separate PR for every branch (main and v8) as needed.
Description of the Change
We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.
Why Is This PR Valuable?
What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?
Applicable Issues
List any applicable GitHub Issues here
How Urgent Is The Change?
Is the change urgent? If so, explain why it is time-sensitive.
Other Relevant Parties
Who else is affected by the change?