Provide raw Linux and AppImage builds as part of CI - #365
Conversation
|
GitHub is experiencing worldwide issues with action. I just closed and reopened to trigger the pipelines. |
atsju
left a comment
atsju
left a comment
There was a problem hiding this comment.
Nice work.
could you please update the Documentation with Linux Appimage usage ? Then we have both compile and usage documentation for all 3 platforms.
Also it would be great to have the "Comment PR with artifact link" comment all 3 binaries (Win, MacOS, Linux) at once when all build success. It should probably be implemented in a separate PR.
| # cheap to install everywhere. libqwt-qt5-* dropped: Qwt is built from | ||
| # source below and the distro Qt5 flavor was never linked against. |
There was a problem hiding this comment.
thank you for this change comment. Should probably be removed in source
| - name: Pack bare build | ||
| run: tar -czf DFTFringe-bare-${{ matrix.os }}.tar.gz DFTFringe | ||
| - name: Upload bare build | ||
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: DFTFringe-bare-${{ matrix.os }} | ||
| path: DFTFringe-bare-${{ matrix.os }}.tar.gz | ||
| if-no-files-found: error |
There was a problem hiding this comment.
It's unclear to me, why do we upload the bare build ? I though we require mainly the appImage for end user
There was a problem hiding this comment.
I should have explained it better as part of the initial PR. Some linux users (me included) prefer bare builds, but with your comment I'm starting to think that kind of user can just compile themselves. Let's focus on AppImages
There was a problem hiding this comment.
From my understanding this is too OS-specific to distribute. I agree those people can build easily themselfs.
Co-authored-by: Julien Staub <atsju2@yahoo.fr>
|
I also forgot to mention: |
|
I think this is ready too, it runs fine on various *buntu derivatives. |
There was a problem hiding this comment.
Code looks good.
Generated .appimage runs in my WSL ubuntu. Everything is fine
Note: build-linux actions are hanging right now. I believe there is a problem with some apt mirrors. I suppose it will fix itself in coming hours. It solved itself as expected
|
You don't need my approval at this point, right? I can't wait until it's working so I can try out the AppImage. |
|
@gr5 you can already try the app image. It's in the build artifacts. I can link you if you need. We can probably modify the "new build artifact" to have all 3 OS in same comment. Can do in a futur PR. |
|
Bottom of page here https://github.com/githubdoe/DFTFringe/actions/runs/32247235250 |
|
I looked through the build artficats but couldn't find it. Thanks. It seems to work just fine in Ubuntu. |
4 participants
Hello,
The idea is to provide both bare compilation outputs (should run under most *buntu flavors provided you have qt installed) and an AppImage build (assembled under 22.04 only for wider compatibility) as part of CI. This is quite cheap since the builds were already done.
@atsju I looked into QT Installer Framework, but from my understanding it wouldn't make the overall build workflow shorter. It could be used to integrate more tightly with desktop OSes (provide menus, icons, etc) but this would be another scope.
Another great next step would be to actually launch DFTFringe in a desktop *buntu container to catch eventual regressions on Linux since there aren't that many users. I will see if that's doable next week.