Repository navigation
test(bigquery): accept cancelled outcome in job cancel acceptance tests - #36657
Merged
Merged
Conversation
Two acceptance tests cancel a load job and then assert it didn't fail, which only holds if the job finishes before the cancel lands. BigQuery now honors the cancel (errorResult reason "stopped"), so the tests fail on main. Accept either a successful job or a cancellation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "creates and cancels jobs" and "creates, cancels and gets a job with location" acceptance tests cancel a load job and then assert that it didn't fail. That only holds if the job finishes before the cancel lands. BigQuery now honors the cancel, so the job ends with an error result whose reason is "stopped". This change accepts either outcome: a successful job, or one that was stopped by the cancellation. Any other error still fails the test.