feat(factory): add fixture-only ChatGPT Skills handoff - #1952
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 PR Validation |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches. Re-running this action after a short time may resolve the issue. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files
|
Execution receipt — 2026-09-15Decision: TEST Mutation
Verification
Evidence boundaryThis fixture verifies the MCP Skills package contract only. ChatGPT is marked Partial in the official MCP matrix; no live ChatGPT import or conformance was observed. Current stateOpen, draft, mergeable, and unmerged. No live import, remote-skill execution, deployment, provider spend, or external effect occurred. Neon receipt: |
There was a problem hiding this comment.
🟡 Changes recommended
The wire model is incompatible with the pinned specification, and approval identity and URI confinement are not securely enforced.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds a fixture-only MCP Skills handoff receipt for ChatGPT without external execution.
Changes:
- Validates skill manifests, resources, capabilities, and cache metadata.
- Adds handoff receipt tests.
- Updates SEP-2640 documentation.
File summaries
| File | Description |
|---|---|
docs/mcp-skills-sep-2640-watch.md |
Updates adoption status and trust boundaries. |
apps/web/src/lib/chatgpt-mcp-skill-import.ts |
Implements fixture validation and receipts. |
apps/web/src/lib/__tests__/chatgpt-mcp-skill-import.test.ts |
Tests validation and authorization behavior. |
Review details
Suppressed comments (1)
apps/web/src/lib/tests/chatgpt-mcp-skill-import.test.ts:154
- The official dynamic form is
skill.resources === "dynamic"; individual resource digests and sizes are never"dynamic". This test therefore covers an invented payload and misses the actual input, which currently reaches.mapon a string and throws an incidentalTypeErrorinstead of the contract's deliberate hold. Exercise the top-level dynamic form after modeling it inSkillGetResult.
const dynamic = fixture();
dynamic.result.skill.resources[1] = {
uri: GUIDE_URI,
digest: 'dynamic',
size: 'dynamic',
};
expect(() => createFixtureChatGptSkillImport(dynamic)).toThrow(/dynamic resources/i);
- Files reviewed: 3/3 changed files
- Comments generated: 4
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@copilot review Re-review exact head |
Re-reviewed |
Merge execution receipt — 2026-09-16Decision: ADOPT + TEST Corrections before mergeThe earlier acceptance of head The final head fixes all four findings, resolves all review threads, validates complete YAML frontmatter, binds approval to A connector publication error also temporarily corrupted Exact-head verification
E2E 3766 did not execute: preview discovery failed because the Vercel deployment was canceled, then dependency installation and E2E steps were skipped. No preview, deployment, live ChatGPT import, or production-execution claim is made. Merge guardThe merge used GitHub expected-head protection for |
Canonical issue
Closes #1640
Outcome
Adds a fixture-only Agent Factory handoff for the ChatGPT MCP Skills distribution path. The contract validates the official MCP Skills wire data and emits a machine-readable receipt without contacting ChatGPT, importing a skill, dispatching a tool, or granting authority.
Scope
io.modelcontextprotocol/skillscapability negotiation.skills/getcomplete responses with required cache metadata.{server_identity, skill_uri}.Evidence boundary
The matrix lists ChatGPT support as Partial. This PR makes no live-client compatibility or conformance claim.
Verification
Current head:
f99f6501d87701dce876b89b8493c5d0dfa6b8e1www.youtube.comreturnedEAI_AGAIN; required repository CI is the authoritative broader checkSafety boundary
Agent handoff