fix(media): preserve zero end times#2542
Open
tianma-if wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-end="0"in generated media synchronization codeWhy
The previous
parseFloat(media.dataset.end) || Infinityfallback treated a valid zero as missing. Media with an explicit zero end time was therefore considered active indefinitely.Validation
bunx oxfmtandbunx oxlinton all changed filesbun run --filter @hyperframes/core test -- hyperframes.test.ts(29 passed)bun run --filter @hyperframes/parsers test -- gsapParser.test.ts(202 passed)