Skip to content

fix(media): preserve zero end times #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tianma-if wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(media): preserve zero end times #2542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/core/src/generators/hyperframes.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,8 @@ describe("generateGsapTimelineScript", () => {

expect(script).toContain("Sync media playback");
expect(script).toContain("media.currentTime");
expect(script).toContain("Number.isFinite(parsedEnd) ? parsedEnd : Infinity");
expect(script).not.toContain("parseFloat(media.dataset.end) || Infinity");
});

it("generates initial position sets for elements with x/y offsets", () => {
Expand Down
3 changes: 2 additions & 1 deletion packages/core/src/generators/hyperframes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,8 @@ function generateDefaultGsapAnimations(
const time = tl.time();
document.querySelectorAll("video[data-start], audio[data-start]").forEach(function(media) {
const start = parseFloat(media.dataset.start);
const end = parseFloat(media.dataset.end) || Infinity;
const parsedEnd = parseFloat(media.dataset.end);
const end = Number.isFinite(parsedEnd) ? parsedEnd : Infinity;
const mediaTime = time - start;
if (time >= start && time < end) {
if (Math.abs(media.currentTime - mediaTime) > 0.1) {
Expand Down
7 changes: 7 additions & 0 deletions packages/parsers/src/gsapParser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,6 +948,13 @@ describe("serializeGsapAnimations", () => {
expect(result).toContain("const myTimeline = gsap.timeline({ paused: true });");
expect(result).toContain('myTimeline.set("#el1"');
});

it("preserves a zero media end time", () => {
const result = serializeGsapAnimations([], "tl", { includeMediaSync: true });

expect(result).toContain("Number.isFinite(parsedEnd) ? parsedEnd : Infinity");
expect(result).not.toContain("parseFloat(media.dataset.end) || Infinity");
});
});

describe("validateCompositionGsap", () => {
Expand Down
3 changes: 2 additions & 1 deletion packages/parsers/src/gsapSerialize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,8 @@ export function serializeGsapAnimations(
const time = ${timelineVar}.time();
document.querySelectorAll("video[data-start], audio[data-start]").forEach(function(media) {
const start = parseFloat(media.dataset.start);
const end = parseFloat(media.dataset.end) || Infinity;
const parsedEnd = parseFloat(media.dataset.end);
const end = Number.isFinite(parsedEnd) ? parsedEnd : Infinity;
const mediaTime = time - start;
if (time >= start && time < end) {
if (Math.abs(media.currentTime - mediaTime) > 0.1) {
Expand Down