fix(registry): register device timeline synchronously#2546
Open
tianma-if wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vfx-iphone-devicepaused timeline synchronouslyrequestAnimationFramegate from composition startupWhy
The block previously exposed
window.__timelines["devices-canvas"]only after both GLTF models loaded and two animation frames elapsed. That violates the synchronous timeline contract and can make renderers wait for the sub-composition polling timeout.Fixes the device-timeline portion of #2107.
Validation
bunx oxfmt registry/blocks/vfx-iphone-device/vfx-iphone-device.htmllintHyperframeHtml: 0 errors (2 existing tween-overlap warnings)npx hyperframes checkagainst a temporary project copy: Runtime 0 errors, Motion 0 errors; the overall command remains non-zero because the existing hidden screen-texture DOM triggers 18 layout occlusion findings unrelated to this change