Skip to content

fix(registry): register device timeline synchronously #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tianma-if wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(registry): register device timeline synchronously #2546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions registry/blocks/vfx-iphone-device/vfx-iphone-device.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,14 +614,8 @@
});

function onReady() {
requestAnimationFrame(function () {
requestAnimationFrame(function () {
paintReady = true;
captureScreens();
window.__timelines = window.__timelines || {};
window.__timelines["devices-canvas"] = tl;
});
});
paintReady = true;
captureScreens();
}

// ── Cubic Bezier Implementation ────────────────────────────────────
Expand Down Expand Up @@ -757,8 +751,9 @@
}

// ── GSAP Timeline — Product Review Edit ────────────────────────────
// __timelines created in onReady() after GLTF models load
var tl = gsap.timeline({ paused: true });
window.__timelines = window.__timelines || {};
window.__timelines["devices-canvas"] = tl;

tl.to(S, { p: 1, drift: 15, duration: 15, ease: "none", onUpdate: render }, 0);

Expand Down Expand Up @@ -812,8 +807,6 @@
// Scroll on MacBook reveal
tl.to(S, { scroll: 0.8, duration: 3, ease: breatheEase }, 9.5);
tl.to(S, { scroll: 0.3, duration: 2, ease: driftEase }, 13);

// __timelines registered in onReady() after GLTF models load
</script>
</body>
</html>