test: remove obsolete debugger pre-break handling#64185
Open
inoway46 wants to merge 1 commit into
Open
Conversation
Signed-off-by: inoway46 <inoueyuya416@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isPreBreakwas a compatibility branch for the old node-inspect-era CommonJS wrapper display.In the current default CommonJS loading path,
lib/internal/modules/cjs/loader.jsusescompileFunctionForCJSLoaderto compile the original file source directly, so the initial break is shown at the user code line, e.g.> 1 const x = 10;.node/lib/internal/modules/cjs/loader.js
Line 1879 in ed33ae7
As a result, the branch that detects
1 (function (exportsand sendsnextis not reached by the normal debugger tests and has become unnecessary legacy compatibility code.This also removes the old optional wrapper pattern from the
test-debugger-break.jsexpectation.Background
While investigating flakes around
waitForInitialBreak(), this branch stood out as unused in the current default path so this PR removes it.