Skip to content

test: remove obsolete debugger pre-break handling #64185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
inoway46 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −10
Open

test: remove obsolete debugger pre-break handling #64185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions test/common/debugger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ if (common.isWindows || common.isMacOS) {
TIMEOUT = common.platformTimeout(15000);
}

function isPreBreak(output) {
return /Break on start/.test(output) && /1 \(function \(exports/.test(output);
}

function startCLI(args, flags = [], spawnOpts = {}, opts = { randomPort: true }) {
let stderrOutput = '';
const child = spawn(process.execPath, [
Expand Down Expand Up @@ -114,11 +110,6 @@ function startCLI(args, flags = [], spawnOpts = {}, opts = { randomPort: true })

async waitForInitialBreak() {
await this.waitFor(/break (?:on start )?in/i);

if (isPreBreak(this.output)) {
await this.command('next', false);
return this.waitFor(/break in/);
}
},

get breakInfo() {
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-debugger-break.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const cli = startCLI([script]);
);
assert.match(
cli.output,
/> 1 (?:\(function \([^)]+\) \{ )?const x = 10;/,
/> 1 const x = 10;/,
'shows the source and marks the current line');

await cli.stepCommand('n');
Expand Down
Loading