Repository navigation
Pin pytest below 9.2 until pytest-benchmark is fixed - #1248
Merged
csmarchbanks merged 1 commit intoOct 30, 2026
Merged
Conversation
csmarchbanks
marked this pull request as ready for review
October 30, 2026 16:38
pytest 9.2 removed Node._nodeid, which pytest-benchmark 5.3.0 still reads, so test_benchmark_text_string_to_metric_families errors at setup. The fix (ionelmc/pytest-benchmark#323) is merged but not yet released. Assisted-by: Claude Sonnet 5.5 Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
csmarchbanks
force-pushed
the
pin-pytest-below-9.2
branch
from
October 30, 2026 16:41
60a172e to
578f86f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest 9.2 (released 2026-10-27) removed
Node._nodeid, which pytest-benchmark 5.3.0 and older still read (ionelmc/pytest-benchmark#321). Since thentest_benchmark_text_string_to_metric_familieserrors at fixture setup on every CI run:The fix (ionelmc/pytest-benchmark#323) is merged but not yet released. Until it is, pin
pytest<9.2intox.iniso the benchmark test keeps running instead of being skipped. The pin should be dropped once a fixed pytest-benchmark is out.Alternative to #1245, which skips the test instead.
Verified locally with
tox -e py3.14: 428 passed, 14 skipped, and the benchmark test runs.🤖 Generated with Claude Code