Skip to content

[Core] Explicit x vector in getPotentialEnergy - #6288

Open
alxbilger wants to merge 6 commits into
sofa-framework:masterfrom
alxbilger:explicitpotentialenergy
Open

alxbilger wants to merge 6 commits into
sofa-framework:masterfrom
alxbilger:explicitpotentialenergy

Conversation

@alxbilger

@alxbilger alxbilger commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Allow to define the x vector as an input of getPotentialEnergy, instead of implicitly relying on the x vector from mparams.

Similar to #6281

[ci-depends-on https://github.com/SofaDefrost/Cosserat/pull/188]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: breaking Change possibly inducing a compilation error pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Sep 2, 2026
@alxbilger
alxbilger force-pushed the explicitpotentialenergy branch from 8e16337 to 31e974e Compare September 25, 2026 12:50
@sofabot

sofabot commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #2.

To unlock the merge button, you must

@hugtalbot

hugtalbot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

minor conflict @alxbilger but I prefer letting you fix it, then ✔️

@alxbilger
alxbilger force-pushed the explicitpotentialenergy branch 2 times, most recently from c732883 to 93d5294 Compare October 8, 2026 07:00
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 8, 2026
@hugtalbot

Copy link
Copy Markdown
Contributor

I just merged the previous one @alxbilger
therefore a few minor conflicts as expected

@alxbilger
alxbilger force-pushed the explicitpotentialenergy branch from d2c8704 to 0969a55 Compare October 9, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: breaking Change possibly inducing a compilation error pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants