feat: server function inspector - #2049
Conversation
🦋 Changeset detectedLatest commit: 204e0f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
7932c2f to
25b3f44
Compare
4bf69fa to
830f1ce
Compare
be34d27 to
25b0ce5
Compare
820baec to
db436df
Compare
db436df to
0defa47
Compare
860f37b to
8ea8a8b
Compare
c84c5ea to
78c44de
Compare
brenelz
left a comment
There was a problem hiding this comment.
Do we just go ahead with this. I feel its pretty isolated
|
@brenelz yes exactly, it's supposed to be non-blocking. I'm planning on working on the new superfeature for the dev overlay on a separate branch. |
fc77b8b to
ab72e93
Compare
b2926bb to
518af61
Compare
|
Failing tests... Can probably get this merged soon after |
|
@brenelz the PR isn't final so it's expected. I don't think I can finalize this before stable, but I'll still try. |
|
Can maybe target 3.0 then. Thats fine |
|
no not 3.0. This is going to ship in 2.0 perhaps in a minor release, just not the RC |
ca69989 to
fca0400
Compare
|
Changeset missing. |
640ad60 to
0d55980
Compare
|
@birkskyum this is meant to be part of 2.0 |
|
Great, and regarding the main branch, how would you prefer we proceed? do we make a revert, or will you make a follow-up pr with the remaining changes, or is this feature already finished? |
PR Checklist
Server function inspector, keeps track of server function calls and allows you to inspect both Response and Request easier (than viewing the network tab).
Some TODOs:
multipart/form-datainspectorArrayBufferand other content-typesAlso some UI cleanup to dedupe stuff from the current DevOverlay
Testing
The overlay isn't visually-accessible for now so if you want to open it, go to Console then enter__START_SERVER_FN__(true)The inspector is now available in the reworked dev overlay. Design is still to be finalized.
Note
seroval branch doesn't depend on this one, I can rebase this to main when that happens