Repository navigation
Conversation
oech3
marked this pull request as draft
November 11, 2026 06:19
oech3
force-pushed
the
fobsd
branch
3 times, most recently
from
November 11, 2026 12:50
34ac8d6 to
92e8f93
Compare
oech3
commented
Nov 11, 2026
oech3
force-pushed
the
fobsd
branch
3 times, most recently
from
November 11, 2026 18:25
5a77e3f to
3e13db4
Compare
oech3
marked this pull request as ready for review
November 11, 2026 18:26
oech3
force-pushed
the
fobsd
branch
3 times, most recently
from
November 11, 2026 19:06
7dacb55 to
2c83be2
Compare
sylvestre
reviewed
Nov 11, 2026
oech3
force-pushed
the
fobsd
branch
6 times, most recently
from
November 12, 2026 03:01
454388d to
a271f50
Compare
Contributor
|
thanks for the work on this! |
Contributor
Author
|
It is because all features which has real consumers on OpenBSD are pulled by feat_Tier1,feat_require_unix,openssl.
So it is still worth to test cksum,openssl . But uucore with all features pulls unused code.
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
oech3
commented
Nov 13, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
I put |
sylvestre
reviewed
Nov 16, 2026
oech3
force-pushed
the
fobsd
branch
5 times, most recently
from
November 16, 2026 17:36
c1238c7 to
21bed84
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Binary size comparison: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build test binaries on Ubuntu and run them on slow VMs.
Actually used features (except for openssl) should be pulled by
feat_os_unixor something else andmake's logic is already tested and different place.(Also we were not testing binaries with openssl actually...)
Note that VM action already have issues about propergation of exit code and build error of crated due to failure of downloading crates.