Skip to content

openbsd.yml: speedup tests - #16340

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:fobsd
Open

oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:fobsd

Conversation

@oech3

@oech3 oech3 commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Build test binaries on Ubuntu and run them on slow VMs.
Actually used features (except for openssl) should be pulled by feat_os_unix or something else and make's logic is already tested and different place.
(Also we were not testing binaries with openssl actually...)

Note that VM action already have issues about propergation of exit code and build error of crated due to failure of downloading crates.

@oech3
oech3 marked this pull request as draft November 11, 2026 06:19
@oech3 oech3 changed the title {free,open}bsd.yml: speedup tests openbsd.yml: speedup tests Nov 11, 2026
@oech3 oech3 closed this Nov 11, 2026
@oech3
oech3 deleted the fobsd branch November 11, 2026 06:34
@oech3
oech3 restored the fobsd branch November 11, 2026 10:29
@oech3 oech3 reopened this Nov 11, 2026
@oech3
oech3 force-pushed the fobsd branch 3 times, most recently from 34ac8d6 to 92e8f93 Compare November 11, 2026 12:50
Comment thread .github/workflows/openbsd.yml Resolved
@oech3
oech3 force-pushed the fobsd branch 3 times, most recently from 5a77e3f to 3e13db4 Compare November 11, 2026 18:25
@oech3
oech3 marked this pull request as ready for review November 11, 2026 18:26
@oech3
oech3 force-pushed the fobsd branch 3 times, most recently from 7dacb55 to 2c83be2 Compare November 11, 2026 19:06
Comment thread .github/workflows/openbsd.yml Resolved
Comment thread .github/workflows/openbsd.yml Resolved
@oech3
oech3 force-pushed the fobsd branch 6 times, most recently from 454388d to a271f50 Compare November 12, 2026 03:01
@oech3
oech3 requested a review from sylvestre November 12, 2026 03:29
@sylvestre

Copy link
Copy Markdown
Contributor

thanks for the work on this!
This drops the uucore --all-features tests and the make build check on both BSDs. Please keep them, or explain why we don't need them anymore.

@oech3

oech3 commented Nov 12, 2026 via email

Copy link
Copy Markdown
Contributor Author

@oech3

This comment was marked as outdated.

@oech3

This comment was marked as resolved.

Comment thread tests/by-util/test_cksum.rs Resolved
@oech3

This comment was marked as outdated.

@oech3

oech3 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

I put -p uucore --all-features as a different job. It saves disk space, drops hack for space, and improves speed since it is not blocked by main test.

Comment thread .github/workflows/openbsd.yml Resolved
Comment thread .github/workflows/openbsd.yml Resolved
Comment thread .github/workflows/openbsd.yml Resolved
Comment thread .github/workflows/openbsd.yml Resolved
Comment thread tests/by-util/test_cksum.rs Resolved
@oech3
oech3 force-pushed the fobsd branch 5 times, most recently from c1238c7 to 21bed84 Compare November 16, 2026 17:36
@oech3

This comment was marked as resolved.

@github-actions

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 155.49 MB (+108 KB, +0.07%)

Significant per-binary changes:
  env     1.20 MB ->    1.28 MB  (+80 KB, +6.51%)

@oech3
oech3 requested a review from sylvestre November 18, 2026 06:36

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants