Skip to content

freebsd.yml: bump freebsd-vm for newer ABI - #16359

Merged
cakebaker merged 1 commit into
uutils:mainfrom
oech3:fbsd-rust-abi
Nov 17, 2026
Merged

cakebaker merged 1 commit into
uutils:mainfrom
oech3:fbsd-rust-abi

Conversation

@oech3

@oech3 oech3 commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #16342

Since exit code is already broken, there is no reason to avoid updating.
Fixes #3779

@oech3
oech3 force-pushed the fbsd-rust-abi branch 7 times, most recently from ebc78df to 0882722 Compare November 12, 2026 06:11
@oech3
oech3 force-pushed the fbsd-rust-abi branch 2 times, most recently from c007dc2 to 1887bdb Compare November 12, 2026 07:22
@codspeed

codspeed Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will improve performance by ×3.2

2 warnings, 1 note

⚠️ 117 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 1 benchmark with a significant change ran on different hardware

Its base and head results were measured on machines with a different CPU, core count or memory, so the change might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

⚡ 2 improved benchmarks
✅ 403 untouched benchmarks
🆕 8 new benchmarks
⏩ 70 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Memory factor_small_factors_and_a_large_prime 104.8 KB 15.4 KB ×6.8
⚡ CPU Simulation factor_small_factors_and_a_large_prime 1,012.7 µs 682 µs +48.49%
🆕 Memory factor_batch_of_largest_u64s N/A 796 KB N/A
🆕 Memory factor_batch_of_semiprimes N/A 199.5 KB N/A
🆕 Memory factor_batch_of_small_numbers N/A 7.5 MB N/A
🆕 Memory factor_batch_of_smallest_u128s N/A 885.4 KB N/A
🆕 CPU Simulation factor_batch_of_largest_u64s N/A 557.4 ms N/A
🆕 CPU Simulation factor_batch_of_semiprimes N/A 794.2 ms N/A
🆕 CPU Simulation factor_batch_of_small_numbers N/A 138.6 ms N/A
🆕 CPU Simulation factor_batch_of_smallest_u128s N/A 516.3 ms N/A

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:fbsd-rust-abi (1716b26) with main (fca3de1)2

Open in CodSpeed

Footnotes

  1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (5159884) during the generation of this report, so fca3de1 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)

@oech3

oech3 commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

@cakebaker Would you review this? I'd like to hurry since this silent breakage.

@cakebaker
cakebaker merged commit 753b311 into uutils:main Nov 17, 2026
194 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

}

#[test]
#[cfg_attr(target_os = "freebsd", ignore = "failed on freebsd-vm@v1.6.0")]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are not failing specifically on freebsd-vm@v1.6.0; they are presumably failing on FreeBSD in general, but the job was being incorrectly reported as successful under freebsd-vm@v1.3.9.

@oech3
oech3 deleted the fbsd-rust-abi branch November 17, 2026 14:44
@xtqqczze

Copy link
Copy Markdown
Collaborator

We should track the failing tests in an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants