Remove unnecessary slice (s) LogicNets from sign_extended and zero_extended.#496
Open
fdxmw wants to merge 5 commits into
Open
Remove unnecessary slice (s) LogicNets from sign_extended and zero_extended.#496fdxmw wants to merge 5 commits into
s) LogicNets from sign_extended and zero_extended.#496fdxmw wants to merge 5 commits into
Conversation
…zero_extended`. This removes 9% of pyrtlnet's slice (`s`) `LogicNets`, and 6% of pyrtlnet's wire (`W`) `WireVectors`, without introducing any new `LogicNets` or `WireVectors`. This speeds up simulation times, especially with `pyrtl.Simulation`. Fix tests broken by this change.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #496 +/- ##
=============================================
- Coverage 92.2% 92.1% -0.0%
=============================================
Files 30 30
Lines 7465 7462 -3
=============================================
- Hits 6876 6872 -4
- Misses 589 590 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
We lost coverage for this case because `sign_extended` no longer generates slices that copy the most significant bit.
…e bit multiple times. This case no longer occurs now that `sign-extended` `concats` multiple copies of the most significant bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes 9% of pyrtlnet's slice (
s)LogicNets, and 6% of pyrtlnet's wire (W)WireVectors, without introducing any newLogicNetsorWireVectors. This speeds up simulation times, especially withpyrtl.Simulation.Fix tests broken by this change.