ci(generation): skip files inheriting coordinates in release check#12850
ci(generation): skip files inheriting coordinates in release check#12850
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the check_existing_release_versions.sh script to skip POM files that lack explicit group_id or version declarations, treating them as inheriting coordinates rather than errors. Feedback suggests reordering the validation logic to ensure the mandatory artifact_id is checked first, preventing the script from incorrectly skipping malformed files, and improving the formatting of error messages.
| exit 1 | ||
| fi | ||
| if [ -z "${group_id}" ] || [ -z "${version}" ]; then | ||
| echo "Skipping file without explicit coordinates (likely inherits): $pom_file" |
There was a problem hiding this comment.
This will skip the case where group ID is inherited and version is wrong.
suztomo
left a comment
suztomo
left a comment
There was a problem hiding this comment.
This will skip the case where group ID is inherited and version is wrong.
This is a corner case not worth implementing artifact inheritance resolution.
3 participants
Fixes #12840