Skip to content

ci(generation): skip files inheriting coordinates in release check #12850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meltsufin merged 3 commits into from
Apr 20, 2026
+6 −2
Merged

ci(generation): skip files inheriting coordinates in release check #12850

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b21994
ci(generation): skip files inheriting coordinates in release check
meltsufin Apr 18, 2026
06d6a50
ci(generation): fail on missing artifactId before skipping
meltsufin Apr 18, 2026
2364fd8
Merge branch 'main' into fix-release-check-inheritance
meltsufin Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions generation/check_existing_release_versions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,14 @@ function find_existing_version_pom() {
local version=$(xmllint --xpath '/*[local-name()="project"]/*[local-name()="version"]/text()' \
"${pom_file}")
echo -n "Checking ${group_id}:${artifact_id}:${version}:"
if [ -z "${group_id}" ] || [ -z "${artifact_id}" ] || [ -z "${version}" ]; then
echo "Couldn't parse the pom file: $pom_file"
if [ -z "${artifact_id}" ]; then
echo "Couldn't parse artifact_id in the pom file: $pom_file"
exit 1
fi
if [ -z "${group_id}" ] || [ -z "${version}" ]; then
echo "Skipping file without explicit coordinates (likely inherits): $pom_file"
Copy link
Copy Markdown
Member

@suztomo suztomo Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will skip the case where group ID is inherited and version is wrong.

return 0
fi
if [[ "${version}" == *SNAPSHOT* ]] && [ "${artifact_id}" != "google-cloud-java" ]; then
echo " Release Please pull request contains SNAPSHOT version. Please investigate."
return_code=1
Expand Down
Loading