Repository navigation
split: use dd in the early-exiting filter test - #16603
Merged
Merged
Conversation
Contributor
|
|
This was referenced Nov 17, 2026
Contributor
|
The corresponding test is passing https://github.com/uutils/coreutils/actions/runs/44019927376/job/133935658473?pr=16603#step:4:6252 . @cakebaker Is this OK to merge? |
Collaborator
|
/rerun make |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_number_filter_exiting_early_keeps_other_chunks(added in #16517) useshead -c1as the filter, but-cis not in POSIXheadand OpenBSD'sheadrejects it, so the OpenBSD job on main fails withhead: unknown option -- c.Use
dd bs=1 count=1instead. It is POSIX and also exits after reading one byte, so the test still covers a filter that quits early. With the split source from before #16517 the updated test still fails.