Skip to content

split: use dd in the early-exiting filter test - #16603

Merged
cakebaker merged 1 commit into
uutils:mainfrom
costajohnt:split-filter-test-openbsd
Nov 17, 2026
Merged

cakebaker merged 1 commit into
uutils:mainfrom
costajohnt:split-filter-test-openbsd

Conversation

@costajohnt

Copy link
Copy Markdown
Contributor

test_number_filter_exiting_early_keeps_other_chunks (added in #16517) uses head -c1 as the filter, but -c is not in POSIX head and OpenBSD's head rejects it, so the OpenBSD job on main fails with head: unknown option -- c.

Use dd bs=1 count=1 instead. It is POSIX and also exits after reading one byte, so the test still covers a filter that quits early. With the split source from before #16517 the updated test still fails.

@oech3

oech3 commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

I don't want to depend on system binary. Is it able to do everything in Rust? But no need to be part of this PR since we need to hurry fixing CI. Oh, it is impossible.

@oech3

oech3 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

The corresponding test is passing https://github.com/uutils/coreutils/actions/runs/44019927376/job/133935658473?pr=16603#step:4:6252 .

@cakebaker Is this OK to merge?

@xtqqczze

Copy link
Copy Markdown
Collaborator

/rerun make
/rerun OpenBSD

@xtqqczze
xtqqczze requested a review from cakebaker November 17, 2026 15:02
@cakebaker
cakebaker merged commit 36079aa into uutils:main Nov 17, 2026
92 of 101 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants